Skip to content

[SPARK-15009][PYTHON][FOLLOWUP] Add default param checks for CountVectorizerModel #20942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BryanCutler wants to merge 1 commit into from
Closed

[SPARK-15009][PYTHON][FOLLOWUP] Add default param checks for CountVectorizerModel #20942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add default param checks for CountVectorizerModel
  • Loading branch information
@BryanCutler
BryanCutler committed Mar 29, 2018
commit ecafd2bcc7661e7f635473aea84eed5fcab2f211
5 changes: 5 additions & 0 deletions python/pyspark/ml/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2096,6 +2096,11 @@ def test_java_params(self):
# NOTE: disable check_params_exist until there is parity with Scala API
ParamTests.check_params(self, cls(), check_params_exist=False)

# Additional classes that need explicit construction
from pyspark.ml.feature import CountVectorizerModel
ParamTests.check_params(self, CountVectorizerModel.from_vocabulary(['a'], 'input'),
check_params_exist=False)


def _squared_distance(a, b):
if isinstance(a, Vector):
Expand Down