Skip to content

[SPARK-23859][ML] Initial PR for Instrumentation improvements: UUID and logging levels #20982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WeichenXu123 wants to merge 4 commits into from
Closed

[SPARK-23859][ML] Initial PR for Instrumentation improvements: UUID and logging levels #20982

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bef1084
Have instrumentation use uuid & standard logger tags.
MrBago Mar 29, 2018
42c3eca
Log data about logistic regression.
MrBago Mar 15, 2018
8a3ce3e
Add logWarning to instrumentation class.
MrBago Mar 30, 2018
f05bcdf
add logError and fix typo
WeichenXu123 Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Log data about logistic regression.
  • Loading branch information
@MrBago
MrBago committed Mar 30, 2018
commit 42c3eca78a58ddca059b150681a0deaf462981f8
6 changes: 6 additions & 0 deletions mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,12 @@ class LogisticRegression @Since("1.2.0") (
(new MultivariateOnlineSummarizer, new MultiClassSummarizer)
)(seqOp, combOp, $(aggregationDepth))
}
instr.logNamedValue(Instrumentation.loggerTags.numExamples, summarizer.count)
if (labelSummarizer.numClasses == 2) {
val b = labelSummarizer.histogram(0) / summarizer.count
instr.logNamedValue("lowestLabelWeight", labelSummarizer.histogram.min.toString)
instr.logNamedValue("highestLabelWeight", labelSummarizer.histogram.min.toString)
}

val histogram = labelSummarizer.histogram
val numInvalid = labelSummarizer.countInvalid
Expand Down
1 change: 1 addition & 0 deletions mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ private[spark] object Instrumentation {
object loggerTags {
val numFeatures = "numFeatures"
val numClasses = "numClasses"
val numExamples = "numExamples"
}

/**
Expand Down