Skip to content

[SPARK-23917][SQL] Add array_max function #21024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgaido91 wants to merge 10 commits into from
Closed

[SPARK-23917][SQL] Add array_max function #21024

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
93c5b8a
[SPARK-23917][SQL] Add array_max function
mgaido91 Apr 10, 2018
a296bc0
fix scalastyle
mgaido91 Apr 10, 2018
c8c1d03
add missing space
mgaido91 Apr 10, 2018
d017ccf
add orderable type check
mgaido91 Apr 10, 2018
e082f00
fix indentation
mgaido91 Apr 10, 2018
a4fd616
address comment
mgaido91 Apr 12, 2018
a78c752
Merge branch 'master' of github.com:apache/spark into SPARK-23917
mgaido91 Apr 12, 2018
8dfd263
update after codegen changes
mgaido91 Apr 12, 2018
e739a0a
fix nullable
mgaido91 Apr 12, 2018
1cde795
address comment
mgaido91 Apr 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix scalastyle
  • Loading branch information
@mgaido91
mgaido91 committed Apr 10, 2018
commit a296bc0db8b8d3befa05b7d0a8faedea4f21a625
2 changes: 1 addition & 1 deletion ...alyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,4 +344,4 @@ case class ArrayMax(child: Expression) extends UnaryExpression with ImplicitCast
case ArrayType(dt, _) => dt
Copy link
Member

@viirya viirya Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also check if dt is orderable.

Copy link
Contributor Author

@mgaido91 mgaido91 Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the check in the checkInputDataTypes method, thanks.

case _ => throw new IllegalStateException("array_max accepts only arrays.")
}
}
}