Skip to content

[SPARK-23930][SQL] Add slice function #21040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgaido91 wants to merge 10 commits into from
Closed

[SPARK-23930][SQL] Add slice function #21040

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5cbbf7a
[SPARK-23930][SQL] Add slice function
mgaido91 Apr 10, 2018
367aaf2
fix typo
mgaido91 Apr 20, 2018
f2784f1
Merge branch 'master' of github.com:apache/spark into SPARK-23930
mgaido91 Apr 20, 2018
b94d067
review comments
mgaido91 Apr 20, 2018
dc6cb60
specialize codegen for primitive types
mgaido91 Apr 27, 2018
72ed607
Merge branch 'master' of github.com:apache/spark into SPARK-23930
mgaido91 Apr 27, 2018
9d65570
fix indent
mgaido91 Apr 30, 2018
9f0deec
Merge branch 'master' into SPARK-23930
mgaido91 May 4, 2018
e2eb21e
add checks for size greater than maxint
mgaido91 May 4, 2018
07604e0
fix scalastyle
mgaido91 May 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix indent
  • Loading branch information
@mgaido91
mgaido91 committed Apr 30, 2018
commit 9d655708c2f0bbf18ab7044fb03cf899a0eba4eb
10 changes: 5 additions & 5 deletions ...alyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,11 +459,11 @@ case class Slice(x: Expression, start: Expression, length: Expression)
}

def genCodeForResult(
ctx: CodegenContext,
ev: ExprCode,
inputArray: String,
startIdx: String,
resLength: String): String = {
ctx: CodegenContext,
ev: ExprCode,
inputArray: String,
startIdx: String,
resLength: String): String = {
val values = ctx.freshName("values")
val i = ctx.freshName("i")
val getValue = CodeGenerator.getValue(inputArray, elementType, s"$i + $startIdx")
Expand Down