Skip to content

[SPARK-23966][SS] Refactoring all checkpoint file writing logic in a common CheckpointFileManager interface #21048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tdas wants to merge 10 commits into from
Closed

[SPARK-23966][SS] Refactoring all checkpoint file writing logic in a common CheckpointFileManager interface #21048

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
df7b339
CheckpointFileManager
tdas Apr 11, 2018
f1fc175
Reduced the public interface further and avoid file deletes in rename
tdas Apr 12, 2018
f9965f1
More improvements
tdas Apr 12, 2018
1b23492
Fixed more tests
tdas Apr 12, 2018
35c6636
Addressed comments
tdas Apr 12, 2018
1818cb2
Removed empty lines
tdas Apr 12, 2018
75b9b18
Merge remote-tracking branch 'apache-github/master' into SPARK-23966
tdas Apr 12, 2018
12177b1
Addressed one more comment
tdas Apr 12, 2018
ef05009
Fixed synchronization bug
tdas Apr 13, 2018
c5b0c98
Addressed comments
tdas Apr 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed synchronization bug
  • Loading branch information
@tdas
tdas committed Apr 13, 2018
commit ef05009e491d1ffdca2a37ba0441ea8507756e3d
10 changes: 8 additions & 2 deletions ...n/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,7 @@ private[state] class HDFSBackedStateStoreProvider extends StateStoreProvider wit
verify(state == UPDATING, "Cannot commit after already committed or aborted")

try {
finalizeDeltaFile(compressedStream)
loadedMaps.put(newVersion, mapToUpdate)
commitUpdates(newVersion, mapToUpdate, compressedStream)
state = COMMITTED
logInfo(s"Committed version $newVersion for $this to file $finalDeltaFile")
newVersion
Expand Down Expand Up @@ -250,6 +249,13 @@ private[state] class HDFSBackedStateStoreProvider extends StateStoreProvider wit

private case class StoreFile(version: Long, path: Path, isSnapshot: Boolean)

private def commitUpdates(newVersion: Long, map: MapType, output: DataOutputStream): Unit = {
synchronized {
finalizeDeltaFile(output)
loadedMaps.put(newVersion, map)
}
}

/**
* Get iterator of all the data of the latest version of the store.
* Note that this will look up the files to determined the latest known version.
Expand Down