Skip to content

[SPARK-23913][SQL] Add array_intersect function #21102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kiszk wants to merge 21 commits into from
Closed

[SPARK-23913][SQL] Add array_intersect function #21102

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
bc5a02d
initial commit
kiszk Apr 18, 2018
c7f230d
simplification
kiszk Apr 18, 2018
e96ab2d
fix pyspark test failure
kiszk Apr 19, 2018
49bc319
update
kiszk Jul 10, 2018
4ec43b1
add missing file
kiszk Jul 10, 2018
2c30351
fix test failure
kiszk Jul 12, 2018
74103ce
update
kiszk Jul 12, 2018
387d0ca
fix compilation failure
kiszk Jul 12, 2018
e374aa9
fix test failures
kiszk Jul 13, 2018
e31f7e6
minor refactoring
kiszk Jul 14, 2018
9818ba9
update
kiszk Jul 16, 2018
352743f
address review comment
kiszk Jul 16, 2018
89a828b
avoid to use OpenHashSet.remove method
kiszk Jul 21, 2018
90fecd5
update dataType setting
kiszk Jul 22, 2018
663358e
update
kiszk Jul 27, 2018
3ef99b8
optimize nullchecks in generated code
kiszk Jul 29, 2018
3462b98
update
kiszk Jul 31, 2018
cf742d4
refactor methods that are used in Except and Intersect
kiszk Aug 2, 2018
6fba1ee
update
kiszk Aug 3, 2018
ce755e2
address review comments
kiszk Aug 6, 2018
33781b6
address review comment
kiszk Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor refactoring
  • Loading branch information
@kiszk
kiszk committed Aug 4, 2018
commit e31f7e67acc4bd41adeff59f237bc7d526aeae07
12 changes: 3 additions & 9 deletions ...alyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4537,9 +4537,7 @@ object ArrayIntersect {
if (!alreadySeenNull) {
var j = 0
while (!found && j < array1.numElements()) {
if (array1.isNullAt(j)) {
found = true
}
found = array1.isNullAt(j)
j += 1
}
// array1 is scaned only once for null element
Expand All @@ -4556,14 +4554,10 @@ object ArrayIntersect {
var k = 0
while (!foundArrayBuffer && k < arrayBuffer.size) {
val va = arrayBuffer(k)
if (va != null && ordering.equiv(va, elem1)) {
foundArrayBuffer = true
}
foundArrayBuffer = (va != null) && ordering.equiv(va, elem1)
k += 1
}
if (!foundArrayBuffer) {
found = true
}
found = !foundArrayBuffer
}
}
j += 1
Expand Down