[SPARK-24021][CORE] fix bug in BlacklistTracker's updateBlacklistForFetchFailure #21104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping @jerryshao |
Contributor
|
Ahh, this looks like a bug I introduced. |
Contributor
|
Jenkins, test this please. |
|
Test build #89542 has finished for PR 21104 at commit
|
jerryshao
approved these changes
Apr 19, 2018
Contributor
|
lgtm, good catch |
asfgit
pushed a commit
that referenced
this pull request
Apr 19, 2018
…etchFailure
## What changes were proposed in this pull request?
There‘s a miswrite in BlacklistTracker's updateBlacklistForFetchFailure:
```
val blacklistedExecsOnNode =
nodeToBlacklistedExecs.getOrElseUpdate(exec, HashSet[String]())
blacklistedExecsOnNode += exec
```
where first **exec** should be **host**.
## How was this patch tested?
adjust existed test.
Author: wuyi <[email protected]>
Closes #21104 from Ngone51/SPARK-24021.
(cherry picked from commit 0deaa52)
Signed-off-by: Imran Rashid <[email protected]>
Contributor
|
merged to master & 2.3.1, thanks! |
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
…etchFailure
## What changes were proposed in this pull request?
There‘s a miswrite in BlacklistTracker's updateBlacklistForFetchFailure:
```
val blacklistedExecsOnNode =
nodeToBlacklistedExecs.getOrElseUpdate(exec, HashSet[String]())
blacklistedExecsOnNode += exec
```
where first **exec** should be **host**.
## How was this patch tested?
adjust existed test.
Author: wuyi <[email protected]>
Closes apache#21104 from Ngone51/SPARK-24021.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There‘s a miswrite in BlacklistTracker's updateBlacklistForFetchFailure:
where first exec should be host.
How was this patch tested?
adjust existed test.