Skip to content

[SPARK-24128][SQL] Mention configuration option in implicit CROSS JOIN error #21201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
henryr wants to merge 2 commits into from
Closed

[SPARK-24128][SQL] Mention configuration option in implicit CROSS JOIN error #21201

henryr wants to merge 2 commits into from

Conversation

@henryr
Copy link
Contributor

@henryr henryr commented May 1, 2018

What changes were proposed in this pull request?

Mention spark.sql.crossJoin.enabled in error message when an implicit CROSS JOIN is detected.

How was this patch tested?

CartesianProductSuite and JoinSuite.

gatorsmile
gatorsmile reviewed May 1, 2018
View reviewed changes
Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile
Copy link
Member

gatorsmile commented May 1, 2018

retest this please

@felixcheung
Copy link
Member

felixcheung commented May 1, 2018

Jenkins, ok to test

@henryr
Copy link
Contributor Author

henryr commented May 1, 2018

retest this please

@SparkQA
Copy link

SparkQA commented May 1, 2018

Test build #89994 has finished for PR 21201 at commit 215b13f.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 1, 2018

Test build #90014 has finished for PR 21201 at commit b267513.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

gatorsmile commented May 2, 2018

retest this please

@SparkQA
Copy link

SparkQA commented May 2, 2018

Test build #90019 has finished for PR 21201 at commit b267513.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member

kiszk commented May 2, 2018

retest this please

@SparkQA
Copy link

SparkQA commented May 2, 2018

Test build #90023 has finished for PR 21201 at commit b267513.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 2, 2018

Test build #90034 has finished for PR 21201 at commit 42d0241.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

gatorsmile commented May 2, 2018

Since this PR also impacts the R tests, we need to wait for fixing CRAN issues. Sorry for the delay.

@henryr
Copy link
Contributor Author

henryr commented May 2, 2018

No problem! It's a small usability fix.

@felixcheung
Copy link
Member

felixcheung commented May 3, 2018

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented May 3, 2018

Test build #90101 has finished for PR 21201 at commit 42d0241.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented May 3, 2018

retest this please

@SparkQA
Copy link

SparkQA commented May 3, 2018

Test build #90109 has finished for PR 21201 at commit 42d0241.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@henryr
Copy link
Contributor Author

henryr commented May 7, 2018

Any chance to get this merged now the tests are working again? Thanks!

@HyukjinKwon
Copy link
Member

HyukjinKwon commented May 8, 2018

Merged to master and branch-2.3.

asfgit pushed a commit that referenced this pull request May 8, 2018
@henryr @HyukjinKwon
[SPARK-24128][SQL] Mention configuration option in implicit CROSS JOI…
4dc6719 
…N error

## What changes were proposed in this pull request?

Mention `spark.sql.crossJoin.enabled` in error message when an implicit `CROSS JOIN` is detected.

## How was this patch tested?

`CartesianProductSuite` and `JoinSuite`.

Author: Henry Robinson <[email protected]>

Closes #21201 from henryr/spark-24128.

(cherry picked from commit cd12c5c)
Signed-off-by: hyukjinkwon <[email protected]>
@asfgit asfgit closed this in cd12c5c May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gatorsmile gatorsmile gatorsmile left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@henryr @gatorsmile @felixcheung @SparkQA @kiszk @HyukjinKwon