Skip to content

[SPARK-3167] Handle special driver configs in Windows #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewor14 wants to merge 10 commits into from
Closed

[SPARK-3167] Handle special driver configs in Windows #2129

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
83ebe60
Parse special driver configs in Windows (broken)
andrewor14 Aug 26, 2014
f97daa2
Fix Windows spark shell stdin issue
andrewor14 Aug 27, 2014
35caecc
In Windows, actually kill Java processes on exit
andrewor14 Aug 27, 2014
eeb34a0
Update outdated comment (minor)
andrewor14 Aug 27, 2014
803218b
Actually respect SPARK_*_CLASSPATH
andrewor14 Aug 27, 2014
72004c2
Actually respect --driver-java-options
andrewor14 Aug 27, 2014
afcffea
Fix style (minor)
andrewor14 Aug 27, 2014
22b1acd
Fix style again (minor)
andrewor14 Aug 27, 2014
92e6047
Update a few comments (minor)
andrewor14 Aug 27, 2014
881a8f0
Add reference to Windows taskkill
andrewor14 Aug 27, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Actually respect SPARK_*_CLASSPATH 
This was simply missing in the existing code.
  • Loading branch information
@andrewor14
andrewor14 committed Aug 27, 2014
commit 803218bd6795ab09d32049e79ea1c11a897a21c7
3 changes: 2 additions & 1 deletion bin/compute-classpath.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ rem Load environment variables from conf\spark-env.cmd, if it exists
if exist "%FWDIR%conf\spark-env.cmd" call "%FWDIR%conf\spark-env.cmd"

rem Build up classpath
set CLASSPATH=%FWDIR%conf
set CLASSPATH=%SPARK_CLASSPATH%;%SPARK_SUBMIT_CLASSPATH%;%FWDIR%conf

if exist "%FWDIR%RELEASE" (
for %%d in ("%FWDIR%lib\spark-assembly*.jar") do (
set ASSEMBLY_JAR=%%d
Expand Down