Skip to content

[SPARK-24187][R][SQL]Add array_join function to SparkR #21313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huaxingao wants to merge 7 commits into from
Closed

[SPARK-24187][R][SQL]Add array_join function to SparkR #21313

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0c6ca7d
[SPARK-24187][R][SQL]Adding array_join function to SparkR
huaxingao May 13, 2018
01858f2
change null_replacement to nullReplacement
huaxingao May 13, 2018
e05e701
resolve conflicts
huaxingao May 14, 2018
92c41c5
address comments
huaxingao Jun 3, 2018
901ff32
change default value to NULL
huaxingao Jun 3, 2018
b0b1415
coerce nullReplacement to character type
huaxingao Jun 4, 2018
55b4518
address comment
huaxingao Jun 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change default value to NULL
  • Loading branch information
@huaxingao
huaxingao committed Jun 3, 2018
commit 901ff32a03c6ec0c16a0ff7c625781ccf2355a54
10 changes: 5 additions & 5 deletions R/pkg/R/functions.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3012,15 +3012,15 @@ setMethod("array_contains",
#' \code{array_join}: Concatenates the elements of column using the delimiter.
#' Null values are replaced with nullReplacement if set, otherwise they are ignored.
#'
#' @param delimiter character(s) to use to concatenate the elements of column.
#' @param nullReplacement character(s) to use to replace the Null values.
#' @param delimiter a character string that is used to concatenate the elements of column.
#' @param nullReplacement a character string that is used to replace the Null values.
Copy link
Member

@felixcheung felixcheung Jun 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you change this to
nullReplacement an optional character string

#' @rdname column_collection_functions
#' @aliases array_join array_join,Column-method
#' @note array_join since 2.4.0
setMethod("array_join",
signature(x = "Column"),
function(x, delimiter, nullReplacement = NA) {
jc <- if (is.na(nullReplacement)) {
signature(x = "Column", delimiter = "character"),
function(x, delimiter, nullReplacement = NULL) {
jc <- if (is.null(nullReplacement)) {
callJStatic("org.apache.spark.sql.functions", "array_join", x@jc, delimiter)
} else {
callJStatic("org.apache.spark.sql.functions", "array_join", x@jc, delimiter,
Expand Down