Skip to content

[SPARK-24414][ui] Calculate the correct number of tasks for a stage. #21457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vanzin wants to merge 1 commit into from
Closed

[SPARK-24414][ui] Calculate the correct number of tasks for a stage. #21457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,7 @@ private[ui] class StagePage(parent: StagesTab, store: AppStatusStore) extends We

val localitySummary = store.localitySummary(stageData.stageId, stageData.attemptId)

val totalTasks = stageData.numActiveTasks + stageData.numCompleteTasks +
stageData.numFailedTasks + stageData.numKilledTasks
val totalTasks = taskCount(stageData)
if (totalTasks == 0) {
val content =
<div>
Expand All @@ -133,7 +132,7 @@ private[ui] class StagePage(parent: StagesTab, store: AppStatusStore) extends We
val totalTasksNumStr = if (totalTasks == storedTasks) {
s"$totalTasks"
} else {
s"$totalTasks, showing ${storedTasks}"
s"$storedTasks, showing ${totalTasks}"
}

val summary =
Expand Down Expand Up @@ -686,7 +685,7 @@ private[ui] class TaskDataSource(

private var _tasksToShow: Seq[TaskData] = null

override def dataSize: Int = stage.numTasks
override def dataSize: Int = taskCount(stage)

override def sliceData(from: Int, to: Int): Seq[TaskData] = {
if (_tasksToShow == null) {
Expand Down Expand Up @@ -1052,4 +1051,9 @@ private[ui] object ApiHelper {
(stage.map(_.name).getOrElse(""), stage.flatMap(_.description).getOrElse(job.name))
}

def taskCount(stageData: StageData): Int = {
stageData.numActiveTasks + stageData.numCompleteTasks + stageData.numFailedTasks +
stageData.numKilledTasks
}

}