address review comments

core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala

@@ -369,8 +369,7 @@ private[spark] class ExternalSorter[K, V, C](
     type Iter = BufferedIterator[Product2[K, C]]
     val heap = new mutable.PriorityQueue[Iter]()(new Ordering[Iter] {
       // Use the reverse of comparator.compare because PriorityQueue dequeues the max
-      // avoid false positive of RV_NEGATING_RESULT_OF_COMPARETO by SpotBugs
-      override def compare(x: Iter, y: Iter): Int = -1 * comparator.compare(x.head._1, y.head._1)
+      override def compare(x: Iter, y: Iter): Int = comparator.compare(y.head._1, x.head._1)
     })
     heap.enqueue(bufferedIters: _*)  // Will contain only the iterators with hasNext = true
     new Iterator[Product2[K, C]] {

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala

@@ -523,8 +523,7 @@ trait ArraySortLike extends ExpectsInputTypes {
         } else if (o2 == null) {
           nullOrder
         } else {
-          // avoid false positive of RV_NEGATING_RESULT_OF_COMPARETO by SpotBugs
-          -1 * ordering.compare(o1, o2)
+          ordering.compare(o2, o1)
         }
       }
     }