Skip to content

[SPARK-19591][ML][MLlib] Add sample weights to decision trees #21632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imatiach-msft wants to merge 13 commits into from
Closed

[SPARK-19591][ML][MLlib] Add sample weights to decision trees #21632

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bf2ceeb
add weights to dt
imatiach-msft Jan 27, 2017
b800cec
updated based on comments
imatiach-msft Dec 19, 2018
52bb65b
updated based on comments
imatiach-msft Jan 6, 2019
d0f0303
updated based on comments
imatiach-msft Jan 7, 2019
14ead10
removed unused method
imatiach-msft Jan 9, 2019
9cd82b6
updated based on comments
imatiach-msft Jan 11, 2019
533d481
fixed tolerance calculation and test
imatiach-msft Jan 11, 2019
dbe0c11
made strategy constructor binary compatible and removed MIMA rule
imatiach-msft Jan 15, 2019
7d2f131
fixed scala style argcount error
imatiach-msft Jan 15, 2019
a8ebf22
removed whitespace
imatiach-msft Jan 22, 2019
a993ce3
increased fraction within tolerance for decision tree regressor test …
imatiach-msft Jan 23, 2019
6adeda8
updated based on comments
imatiach-msft Jan 23, 2019
7d6654e
updated based on comments
imatiach-msft Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
made strategy constructor binary compatible and removed MIMA rule
  • Loading branch information
@imatiach-msft
imatiach-msft committed Jan 15, 2019
commit dbe0c1133dc57def714eae90cafa0307c8ab7a42
23 changes: 23 additions & 0 deletions mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,29 @@ class Strategy @Since("1.3.0") (
isMulticlassClassification && (categoricalFeaturesInfo.size > 0)
}

/**
* Backwards compatible constructor for [[org.apache.spark.mllib.tree.configuration.Strategy]]
*/
@Since("1.0.0")
def this(
algo: Algo,
impurity: Impurity,
maxDepth: Int,
numClasses: Int,
maxBins: Int,
quantileCalculationStrategy: QuantileStrategy,
categoricalFeaturesInfo: Map[Int, Int],
minInstancesPerNode: Int,
minInfoGain: Double,
maxMemoryInMB: Int,
subsamplingRate: Double,
useNodeIdCache: Boolean,
checkpointInterval: Int) {
this(algo, impurity, maxDepth, numClasses, maxBins, quantileCalculationStrategy,
categoricalFeaturesInfo, minInstancesPerNode, minInfoGain, maxMemoryInMB,
subsamplingRate, useNodeIdCache, checkpointInterval, 0.0)
}

/**
* Java-friendly constructor for [[org.apache.spark.mllib.tree.configuration.Strategy]]
*/
Expand Down
5 changes: 1 addition & 4 deletions project/MimaExcludes.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,7 @@ object MimaExcludes {
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.expressions.UserDefinedFunction.copy$default$1"),
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.expressions.UserDefinedFunction.productIterator"),
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.expressions.UserDefinedFunction.productPrefix"),
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.expressions.UserDefinedFunction.copy$default$3"),

// [SPARK-19591][ML] Add sample weights to decision trees
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.mllib.tree.configuration.Strategy.this")
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.expressions.UserDefinedFunction.copy$default$3")
)

// Exclude rules for 2.4.x
Expand Down