[SPARK-24646][CORE] Minor change to spark.yarn.dist.forceDownloadSchemes to support wildcard '*' #21633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
changed the title
|
Test build #92289 has finished for PR 21633 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
|
Test build #92291 has finished for PR 21633 at commit
|
vanzin
reviewed
Jun 28, 2018
Contributor
vanzin
left a comment
vanzin
left a comment
There was a problem hiding this comment.
Looks good, just a couple of minor things.
| "local disk prior to being added to YARN's distributed cache. For use in cases " + | ||
| "where the YARN service does not support schemes that are supported by Spark, like http, " + | ||
| "https and ftp.") | ||
| "https and ftp, or jars required to add to local YARN client's classpath. Wildcard '*' is" + |
Contributor
There was a problem hiding this comment.
"required to be in the local..."
Also, keep the space at the end of this line, like done in others,
docs/running-on-yarn.md
Outdated
| Comma-separated list of schemes for which resources will be downloaded to the local disk prior to | ||
| being added to YARN's distributed cache. For use in cases where the YARN service does not | ||
| support schemes that are supported by Spark, like http, https and ftp. | ||
| support schemes that are supported by Spark, like http, https and ftp, or jars required to add to |
|
Test build #92552 has finished for PR 21633 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
|
Test build #92555 has finished for PR 21633 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
|
Test build #92563 has finished for PR 21633 at commit
|
Contributor
Author
|
Any more comment @vanzin ? |
Contributor
Author
|
Thanks @jiangxb1987 , merging to master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the case of getting tokens via customized
ServiceCredentialProvider, it is required thatServiceCredentialProviderbe available in local spark-submit process classpath. In this case, all the configured remote sources should be forced to download to local.For the ease of using this configuration, here propose to add wildcard '*' support to
spark.yarn.dist.forceDownloadSchemes, also clarify the usage of this configuration.How was this patch tested?
New UT added.