Skip to content

[SPARK-24537][R]Add array_remove / array_zip / map_from_arrays / array_distinct #21645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huaxingao wants to merge 2 commits into from
Closed

[SPARK-24537][R]Add array_remove / array_zip / map_from_arrays / array_distinct #21645

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87100ec
[SPARK-24537][R]Add array_remove / array_zip / map_from_arrays / arra…
huaxingao Jun 26, 2018
1b6a113
address comments
huaxingao Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address comments
  • Loading branch information
@huaxingao
huaxingao committed Jul 11, 2018
commit 1b6a11364da0b99bf44d6c05d448a0e357e320a9
10 changes: 6 additions & 4 deletions R/pkg/R/functions.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,12 @@ NULL
#' \itemize{
#' \item \code{array_contains}: a value to be checked if contained in the column.
#' \item \code{array_position}: a value to locate in the given array.
#' \item \code{array_remove}: a value to remove in the given array.
#' }
#' @param ... additional argument(s). In \code{to_json} and \code{from_json}, this contains
#' additional named properties to control how it is converted, accepts the same
#' options as the JSON data source.
#' options as the JSON data source. In \code{arrays_zip}, this contains additional
#' Columns of arrays to be merged.
#' @name column_collection_functions
#' @rdname column_collection_functions
#' @family collection functions
Expand Down Expand Up @@ -3157,9 +3159,9 @@ setMethod("arrays_overlap",
setMethod("arrays_zip",
signature(x = "Column"),
function(x, ...) {
Copy link
Member

@felixcheung felixcheung Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add in doc that ... are Column for this function
https://github.com/huaxingao/spark/blob/87100ec766acf647e91ab14450f1c33c0f929d52/R/pkg/R/functions.R#L198

jcols <- lapply(list(x, ...), function(x) {
stopifnot(class(x) == "Column")
x@jc
jcols <- lapply(list(x, ...), function(arg) {
stopifnot(class(arg) == "Column")
arg@jc
})
jc <- callJStatic("org.apache.spark.sql.functions", "arrays_zip", jcols)
column(jc)
Expand Down