[SPARK-24675][SQL]Rename table: validate existence of new location #21655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maropu
reviewed
Jun 28, 2018
| tempViews.foreach(kv => target.tempViews.put(kv._1, kv._2)) | ||
| } | ||
|
|
||
| private def validateLocationOfRename(oldName: TableIdentifier, newName: TableIdentifier): Unit = { |
Member
There was a problem hiding this comment.
Can you add code comments along with validateName?
maropu
reviewed
Jun 28, 2018
| } | ||
|
|
||
| test ("rename a managed table with existing empty directory") { | ||
| val tableLoc = new File(spark.sessionState.catalog.defaultTablePath(TableIdentifier("tab2"))) |
Member
There was a problem hiding this comment.
nit: remove the space between test and (.
maropu
reviewed
Jun 28, 2018
| val newTableLocation = new Path(new Path(databaseLocation), formatTableName(newName.table)) | ||
| val fs = newTableLocation.getFileSystem(hadoopConf) | ||
| if (fs.exists(newTableLocation)) { | ||
| throw new AnalysisException(s"Can not rename the managed table('${oldName}')" + |
Member
There was a problem hiding this comment.
nit: remove braces: ${oldName} -> $oldName
maropu
reviewed
Jun 28, 2018
| val fs = newTableLocation.getFileSystem(hadoopConf) | ||
| if (fs.exists(newTableLocation)) { | ||
| throw new AnalysisException(s"Can not rename the managed table('${oldName}')" + | ||
| s". The associated location('${newTableLocation.toString}') already exists.") |
Member
There was a problem hiding this comment.
nit: ${newTableLocation.toString} -> $newTableLocation?
maropu
reviewed
Jun 28, 2018
| val tableLoc = new File(spark.sessionState.catalog.defaultTablePath(TableIdentifier("tab2"))) | ||
| try { | ||
| withTable("tab1") { | ||
| sql(s"CREATE TABLE tab1 USING ${dataSource} AS SELECT 1, 'a'") |
Member
There was a problem hiding this comment.
nit: ${dataSource} -> $dataSource
|
Test build #92417 has finished for PR 21655 at commit
|
|
Test build #92429 has finished for PR 21655 at commit
|
gatorsmile
reviewed
Jul 3, 2018
| requireTableExists(TableIdentifier(oldTableName, Some(db))) | ||
| requireTableNotExists(TableIdentifier(newTableName, Some(db))) | ||
| validateName(newTableName) | ||
| validateNewLocationOfRename(oldName, newName) |
Member
There was a problem hiding this comment.
Add this new behavior to migration guide?
|
Test build #92591 has finished for PR 21655 at commit
|
Member
|
LGTM Thanks! Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If table is renamed to a existing new location, data won't show up.
The file layout is like
In Hive, if the new location exists, the renaming will fail even the location is empty.
We should have the same validation in Catalog, in case of unexpected bugs.
How was this patch tested?
New unit test.