Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Jul 6, 2018

What changes were proposed in this pull request?

We should use DataType.sameType to compare element type in ArrayContains, otherwise nullability affects comparison result.

How was this patch tested?

Added test.

@viirya viirya changed the title [SPARK-24749] Use sameType to compare Array's element type in ArrayContains [SPARK-24749][SQL] Use sameType to compare Array's element type in ArrayContains Jul 6, 2018
@SparkQA
Copy link

SparkQA commented Jul 6, 2018

Test build #92673 has finished for PR 21724 at commit 2c16b4e.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Hm, BTW @viirya,

* checking CRAN incoming feasibility ...Error in .check_package_CRAN_incoming(pkgdir) : 
  dims [product 24] do not match the length of object [0]
Execution halted

This seems the same issue again. I reopened https://issues.apache.org/jira/browse/SPARK-24152.

@viirya
Copy link
Member Author

viirya commented Jul 6, 2018

@HyukjinKwon I've noticed that too and already sent an email to CRAN sysadmin to ask for fixing it. I think it is fixed now.

@viirya
Copy link
Member Author

viirya commented Jul 6, 2018

retest this please.

@SparkQA
Copy link

SparkQA commented Jul 7, 2018

Test build #92700 has finished for PR 21724 at commit 2c16b4e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@asfgit asfgit closed this in fc43690 Jul 7, 2018
@viirya viirya deleted the SPARK-24749 branch December 27, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants