Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

Not a big deal but this PR adds sphinx into dev/requirements.txt since we found it needed - apache/spark-website#122 (comment)

How was this patch tested?

manually:

pip install -r requirements.txt

@HyukjinKwon
Copy link
Member Author

cc @felixcheung

@SparkQA
Copy link

SparkQA commented Jul 9, 2018

Test build #92749 has finished for PR 21735 at commit 038660a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

retest this please

@SparkQA
Copy link

SparkQA commented Jul 10, 2018

Test build #92782 has finished for PR 21735 at commit 038660a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

Merged to master.

@asfgit asfgit closed this in 4984f1a Jul 10, 2018
Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx

@HyukjinKwon
Copy link
Member Author

Thank you @felixcheung.

@HyukjinKwon HyukjinKwon deleted the minor-dev branch October 16, 2018 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants