Skip to content

Conversation

@zoltanctoth
Copy link
Contributor

Fixing the doc as the imputer is not a Transformer but an Estimator.

https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala#L96-L97

What changes were proposed in this pull request?

Simple documentation fix

How was this patch tested?

manual testing

Please review http://spark.apache.org/contributing.html before opening a pull request.

@SparkQA
Copy link

SparkQA commented Jul 15, 2018

Test build #4214 has finished for PR 21755 at commit 19cd33b.

  • This patch fails Spark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 15, 2018

I'm sure the failure is spurious, so merged to master.
PS see https://spark.apache.org/contributing.html

@asfgit asfgit closed this in 5d62a98 Jul 15, 2018
@zoltanctoth zoltanctoth deleted the doc-imputer-is-estimator branch October 8, 2018 18:50
@zoltanctoth
Copy link
Contributor Author

@srowen Just about to submit a new doc relates pull request.
Wondering if your PS see https://spark.apache.org/contributing.html line referred to anything specific about how I should issue these PRs differently?

@srowen
Copy link
Member

srowen commented Oct 8, 2018

Minor stuff: we usually tag this with [MINOR] in the title to be clear there's no JIRA. Also ideal to batch together small related changes but I don't know that there was anything else to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants