Skip to content

[SPARK-24811][SQL]Avro: add new function from_avro and to_avro #21774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengliangwang wants to merge 8 commits into from
Closed

[SPARK-24811][SQL]Avro: add new function from_avro and to_avro #21774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2b78cff
add from_avro and to_avro
gengliangwang Jul 15, 2018
9c185d5
add test suite
gengliangwang Jul 17, 2018
204a59d
add AvroFunctionsSuite
gengliangwang Jul 18, 2018
fb8e50f
address some comments
gengliangwang Jul 19, 2018
833dccc
codegen
gengliangwang Jul 19, 2018
a6dd08f
address comments
gengliangwang Jul 19, 2018
0a6dd0b
address comments
gengliangwang Jul 20, 2018
7179e85
override sql
gengliangwang Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address some comments
  • Loading branch information
@gengliangwang
gengliangwang committed Jul 19, 2018
commit fb8e50f4b31583688aeacfbe753b3cee2469fc31
2 changes: 1 addition & 1 deletion external/avro/src/main/scala/org/apache/spark/sql/avro/CatalystDataToAvro.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import org.apache.spark.sql.types.{BinaryType, DataType}

Copy link
Contributor

@mn-mikke mn-mikke Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExpressionDescription and javadoc?

case class CatalystDataToAvro(child: Expression) extends UnaryExpression with CodegenFallback {

override lazy val dataType: DataType = BinaryType
override def dataType: DataType = BinaryType

@transient private lazy val avroType =
SchemaConverters.toAvroType(child.dataType, child.nullable)
Expand Down
2 changes: 1 addition & 1 deletion external/avro/src/test/scala/org/apache/spark/sql/avro/AvroCatalystDataConversionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ class AvroCatalystDataConversionSuite extends SparkFunSuite with ExpressionEvalH
""".stripMargin

// When read float data as double, avro reader fails(trying to read 8 bytes while the data have
// only 4 bytes), `AvroDataToCatalyst` catches the exception and returns null.
// only 4 bytes).
assertFail(data, new Schema.Parser().parse(avroTypeJson))
}

Expand Down