Skip to content

[SPARK-24609][ML][DOC] PySpark/SparkR doc doesn't explain RandomForestClassifier.featureSubsetStrategy well #21788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhengruifeng wants to merge 1 commit into from
Closed

[SPARK-24609][ML][DOC] PySpark/SparkR doc doesn't explain RandomForestClassifier.featureSubsetStrategy well #21788

zhengruifeng wants to merge 1 commit into from

Conversation

@zhengruifeng
Copy link
Contributor

@zhengruifeng zhengruifeng commented Jul 17, 2018 •
edited
Loading

What changes were proposed in this pull request?

update doc of RandomForestClassifier.featureSubsetStrategy

How was this patch tested?

local built doc

rdoc:
default

pydoc:
default

@SparkQA
Copy link

SparkQA commented Jul 17, 2018

Test build #93162 has finished for PR 21788 at commit b53d14f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 17, 2018

Test build #93171 has finished for PR 21788 at commit 3283acd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 24, 2018

Test build #93472 has finished for PR 21788 at commit 22396b0.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

felixcheung commented Jul 24, 2018

what's changed? it was forced pushed so I can't tell what's updated

@zhengruifeng
Copy link
Contributor Author

zhengruifeng commented Jul 26, 2018

@felixcheung I have to force push it so as to change the git username. I will look for what happend

@zhengruifeng
Copy link
Contributor Author

zhengruifeng commented Jul 26, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Jul 26, 2018

Test build #93583 has finished for PR 21788 at commit 22396b0.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zhengruifeng
Copy link
Contributor Author

zhengruifeng commented Jul 26, 2018

retest this please

felixcheung
felixcheung approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Jul 26, 2018

Test build #93588 has finished for PR 21788 at commit 22396b0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

holdenk
holdenk approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@holdenk holdenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python side looks good to me.

@srowen
Copy link
Member

srowen commented Jul 31, 2018

Merged to master

@asfgit asfgit closed this in 1223a20 Jul 31, 2018
@zhengruifeng zhengruifeng deleted the rf_doc_py_r branch August 1, 2018 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holdenk holdenk holdenk approved these changes

@felixcheung felixcheung felixcheung approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhengruifeng @SparkQA @felixcheung @srowen @holdenk