Skip to content

[SPARK-24424][SQL] Support ANSI-SQL compliant syntax for GROUPING SET #21813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dilipbiswal wants to merge 5 commits into from
Closed

[SPARK-24424][SQL] Support ANSI-SQL compliant syntax for GROUPING SET #21813

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5ada3f
[SPARK-24424] Support ANSI-SQL compliant syntax for GROUPING SET
dilipbiswal Jul 19, 2018
ac8f04f
code review
dilipbiswal Jul 19, 2018
7cf187d
Remove redundant test
dilipbiswal Jul 19, 2018
e0c57f7
Add comment
dilipbiswal Jul 19, 2018
2ecf3e1
Add one more negative test
dilipbiswal Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add one more negative test
  • Loading branch information
@dilipbiswal
dilipbiswal committed Jul 20, 2018
commit 2ecf3e183e51f13ec9c92692d29854f01eb327c5
4 changes: 3 additions & 1 deletion sql/core/src/test/resources/sql-tests/inputs/grouping_set.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ GROUP BY GROUPING SETS ( ( c1 ), ( c2 ) )
HAVING GROUPING__ID > 1;

-- Group sets without explicit group by
SELECT grouping(c1) FROM (VALUES ('x', 'a', 10), ('y', 'b', 20)) AS t (c1, c2, c3) GROUP BY c1,c2 GROUPING SETS (c1,c2);
SELECT grouping(c1) FROM (VALUES ('x', 'a', 10), ('y', 'b', 20)) AS t (c1, c2, c3) GROUP BY GROUPING SETS (c1,c2);

-- Mutiple grouping within a grouping set
SELECT -c1 AS c1 FROM (values (1,2), (3,2)) t(c1, c2) GROUP BY GROUPING SETS ((c1), (c1, c2));
Expand All @@ -49,3 +49,5 @@ SELECT a, b, c, count(d) FROM grouping GROUP BY WITH ROLLUP;

SELECT a, b, c, count(d) FROM grouping GROUP BY WITH CUBE;

SELECT c1 FROM (values (1,2), (3,2)) t(c1, c2) GROUP BY GROUPING SETS (());

13 changes: 11 additions & 2 deletions sql/core/src/test/resources/sql-tests/results/grouping_set.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
-- Automatically generated by SQLQueryTestSuite
-- Number of queries: 14
-- Number of queries: 15


-- !query 0
Expand Down Expand Up @@ -73,7 +73,7 @@ NULL b 20 2


-- !query 7
SELECT grouping(c1) FROM (VALUES ('x', 'a', 10), ('y', 'b', 20)) AS t (c1, c2, c3) GROUP BY c1,c2 GROUPING SETS (c1,c2)
SELECT grouping(c1) FROM (VALUES ('x', 'a', 10), ('y', 'b', 20)) AS t (c1, c2, c3) GROUP BY GROUPING SETS (c1,c2)
-- !query 7 schema
struct<grouping(c1):tinyint>
-- !query 7 output
Expand Down Expand Up @@ -155,3 +155,12 @@ extraneous input 'CUBE' expecting <EOF>(line 1, pos 53)
== SQL ==
SELECT a, b, c, count(d) FROM grouping GROUP BY WITH CUBE
-----------------------------------------------------^^^


-- !query 14
SELECT c1 FROM (values (1,2), (3,2)) t(c1, c2) GROUP BY GROUPING SETS (())
-- !query 14 schema
struct<>
-- !query 14 output
org.apache.spark.sql.AnalysisException
expression '`c1`' is neither present in the group by, nor is it an aggregate function. Add to group by or wrap in first() (or first_value) if you don't care which value you get.;