Skip to content

[SPARK-23731][SQL] Make FileSourceScanExec canonicalizable after being (de)serialized #21815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 4 commits into from
Closed

[SPARK-23731][SQL] Make FileSourceScanExec canonicalizable after being (de)serialized #21815

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22c7986
Make FileSourceScanExec canonicalizable in executor side
HyukjinKwon Jul 19, 2018
b488836
Address comments
HyukjinKwon Jul 19, 2018
7f531bd
Address comments
HyukjinKwon Jul 20, 2018
be6e594
Move test case to SparkPlanSuite
HyukjinKwon Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Move test case to SparkPlanSuite
  • Loading branch information
@HyukjinKwon
HyukjinKwon committed Jul 20, 2018
commit be6e5941991ca045100456e11a59a9b2eb77a1ea
40 changes: 0 additions & 40 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/FileSourceScanExecSuite.scala
View file
Open in desktop

This file was deleted.

17 changes: 17 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.spark.sql.execution

import org.apache.spark.SparkEnv
import org.apache.spark.sql.QueryTest
import org.apache.spark.sql.test.SharedSQLContext

Expand All @@ -33,4 +34,20 @@ class SparkPlanSuite extends QueryTest with SharedSQLContext {
intercept[IllegalStateException] { plan.executeTake(1) }
}

test("SPARK-23731 plans should be canonicalizable after being (de)serialized") {
withTempPath { path =>
spark.range(1).write.parquet(path.getAbsolutePath)
val df = spark.read.parquet(path.getAbsolutePath)
val fileSourceScanExec =
df.queryExecution.sparkPlan.collectFirst { case p: FileSourceScanExec => p }.get
val serializer = SparkEnv.get.serializer.newInstance()
val readback =
serializer.deserialize[FileSourceScanExec](serializer.serialize(fileSourceScanExec))
try {
readback.canonicalized
} catch {
case e: Throwable => fail("FileSourceScanExec was not canonicalizable", e)
}
}
}
}