Skip to content

[SPARK-24934][SQL] Explicitly whitelist supported types in upper/lower bounds for in-memory partition pruning #21882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 3 commits into from
Closed

[SPARK-24934][SQL] Explicitly whitelist supported types in upper/lower bounds for in-memory partition pruning #21882

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a0a2d8
Explicitly whitelist supported types in upper/lower bounds for in-mem…
HyukjinKwon Jul 26, 2018
fe3c0a0
style
HyukjinKwon Jul 28, 2018
deb20ef
Uncache table
HyukjinKwon Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style
  • Loading branch information
@HyukjinKwon
HyukjinKwon committed Jul 28, 2018
commit fe3c0a0254d4db767750d2afa0294ecd2d8ee24f
4 changes: 1 addition & 3 deletions ...e/src/test/scala/org/apache/spark/sql/execution/columnar/PartitionBatchPruningSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,7 @@ class PartitionBatchPruningSuite
testArrayData.map(_._1))
// Do not filter on binary type
checkBatchPruning(
Copy link
Member Author

@HyukjinKwon HyukjinKwon Jul 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this change, Expected Array(Array(1)), but got Array() Wrong query result

query = "SELECT _1 FROM pruningBinaryData WHERE _1 == binary(chr(1))",
expectedReadPartitions = 5,
expectedReadBatches = 10)(Seq(Array(1.toByte)))
"SELECT _1 FROM pruningBinaryData WHERE _1 == binary(chr(1))", 5, 10)(Seq(Array(1.toByte)))

Copy link
Contributor

@mgaido91 mgaido91 Jul 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unneeded blank line

// IS NULL
checkBatchPruning("SELECT key FROM pruningData WHERE value IS NULL", 5, 5) {
Expand Down