-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-24937][SQL] Datasource partition table should load empty static partitions #21883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #93602 has finished for PR 21883 at commit
|
|
Test build #93633 has finished for PR 21883 at commit
|
|
Test build #93645 has finished for PR 21883 at commit
|
|
retest this please |
|
Test build #93652 has finished for PR 21883 at commit
|
| def getPathFragment(partitions: TablePartitionSpec): String = partitions.map { | ||
| case (k, v) => | ||
| escapePathName(k) + "=" + escapePathName(v) | ||
| }.mkString("/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TablePartitionSpec is a map. The output of this func might be different from the actual schema, right?
For example, the partition schema is [partCol1, partCol2]. Your output could place partCol2 before partCol1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Fixed it.
|
Test build #93829 has finished for PR 21883 at commit
|
|
@wangyum How about our Hive tables? Add a test case for Hive tables? They are created by CREATE TABLE instead of CREATE TABLE USING. You can use csv/json format in the test cases. |
|
Test build #93855 has finished for PR 21883 at commit
|
|
retest this please. |
|
Test build #93868 has finished for PR 21883 at commit
|
|
retest this please. |
|
Test build #93886 has finished for PR 21883 at commit
|
|
LGTM Thanks! Merged to master. |
What changes were proposed in this pull request?
How to reproduce:
tbl1is generated.This pr fix this issues.
How was this patch tested?
unit tests