Skip to content

Conversation

@huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

Add numIter to Python version of ClusteringSummary

How was this patch tested?

Modified existing UT test_multiclass_logistic_regression_summary

@holdensmagicalunicorn
Copy link

@huaxingao, thanks! I am a bot who has found some folks who might be able to help with the review:@jkbradley, @mengxr and @yanboliang

@SparkQA
Copy link

SparkQA commented Jul 30, 2018

Test build #93812 has finished for PR 21925 at commit 7cf662b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a follow-up to the change that added this property in Scala, which is going in for 2.4. So I'm inclined to make sure this is in for 2.4 too.

@mgaido91
Copy link
Contributor

LGTM

@srowen
Copy link
Member

srowen commented Jul 31, 2018

Merged to master

@asfgit asfgit closed this in 42dfe4f Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants