Skip to content

Conversation

@gatorsmile
Copy link
Member

What changes were proposed in this pull request?

This PR is to refactor the code in AVERAGE by dsl.

How was this patch tested?

N/A

@holdensmagicalunicorn
Copy link

@gatorsmile, thanks! I am a bot who has found some folks who might be able to help with the review:@rxin, @cloud-fan and @ueshin

@gatorsmile
Copy link
Member Author

@SparkQA
Copy link

SparkQA commented Aug 2, 2018

Test build #93918 has finished for PR 21951 at commit 511b7b6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Aug 2, 2018

Why would we want to use the DSL here? Do we use it in other expressions?

@gatorsmile
Copy link
Member Author

This will simplify the code and improve the readability. We can do the same in the other expression.

@rxin
Copy link
Contributor

rxin commented Aug 2, 2018 via email

@rednaxelafx
Copy link
Contributor

LGTM as well. Thanks a lot!

@cloud-fan
Copy link
Contributor

LGTM. shall we create a JIRA ticket to apply this to other DeclarativeAggregates?

@gatorsmile
Copy link
Member Author

gatorsmile commented Aug 2, 2018

Thanks! Merged to master.

Please ignore the last commit. The last commit is not merged.

@asfgit asfgit closed this in 166f346 Aug 2, 2018
@gatorsmile
Copy link
Member Author

@SparkQA
Copy link

SparkQA commented Aug 2, 2018

Test build #93956 has finished for PR 21951 at commit a5762d7.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants