Skip to content

[SPARK-25117][R] Add EXEPT ALL and INTERSECT ALL support in R #22107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dilipbiswal wants to merge 6 commits into from
Closed

[SPARK-25117][R] Add EXEPT ALL and INTERSECT ALL support in R #22107

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6076700
[SPARK-25117] Add EXEPT ALL and INTERSECT ALL support in R
dilipbiswal Aug 14, 2018
426ffed
minor fix
dilipbiswal Aug 14, 2018
7e88c9d
lint
dilipbiswal Aug 14, 2018
5247ab5
code review
dilipbiswal Aug 15, 2018
1d93304
code review
dilipbiswal Aug 15, 2018
528050d
code review
dilipbiswal Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@dilipbiswal
dilipbiswal committed Aug 14, 2018
commit 7e88c9dd23f0e889f61b6392980363f2b63c0117
8 changes: 4 additions & 4 deletions R/pkg/tests/fulltests/test_sparkSQL.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2494,10 +2494,10 @@ test_that("intersectAll() and exceptAll()", {
df2 <- createDataFrame(
list(list("a", 1), list("a", 1), list("b", 3)),
schema = c("a", "b"))
Copy link
Member

@HyukjinKwon HyukjinKwon Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

df2 <- createDataFrame(list(list("a", 1), list("a", 1), list("b", 3)), schema = c("a", "b"))

intersect_all_expected = data.frame("a" = c("a", "a", "b"), "b" = c(1, 1, 3),
stringsAsFactors = FALSE)
except_all_expected = data.frame("a" = c("a", "a", "c"), "b" = c(1, 1, 4),
stringsAsFactors = FALSE)
intersect_all_expected <- data.frame("a" = c("a", "a", "b"), "b" = c(1, 1, 3),
stringsAsFactors = FALSE)
except_all_expected <- data.frame("a" = c("a", "a", "c"), "b" = c(1, 1, 4),
stringsAsFactors = FALSE)
intersect_all_df <- arrange(intersectAll(df1, df2), df1$a)
Copy link
Member

@HyukjinKwon HyukjinKwon Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly, the naming rule is intersectAllDf or intersect.all.df (see #17590 (comment))

expect_is(intersect_all_df, "SparkDataFrame")
except_all_df <- arrange(exceptAll(df1, df2), df1$a)
Expand Down