Skip to content

Conversation

@LucaCanali
Copy link
Contributor

What changes were proposed in this pull request?

Add description of Task Metrics to the documentation.

How was this patch tested?

None.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

</tr>
<tr>
<td>executorRunTime</td>
<td>Time the executor spent running this task. This includes time fetching shuffle data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Time mean elapsed time or other time?

The value is expressed in milliseconds.</td>
</tr>
<tr>
<td>executorCpuTime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we miss <td> in these two lines?

</tr>
<tr>
<td>jvmGCTime</td>
<td>Amount of time the JVM spent in garbage collection while executing this task.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we start with amount of while the above parameters start Time or CPU Time?

</tr>
<tr>
<td>resultSerializationTime</td>
<td>Amount of time spent serializing the task result.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

</tr>
<tr>
<td>executorCpuTime
<td>CPU Time the executor spent running this task. This includes time fetching shuffle data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: CPU time?

@kiszk
Copy link
Member

kiszk commented Sep 5, 2018

I like to add description for metrics.

@LucaCanali
Copy link
Contributor Author

Thanks @kiszk for reviewing this. I have addressed your comments in a new commit +
apologies as I have now moved this to a new PR #22397
I am closing this to avoid confusion.

@LucaCanali LucaCanali closed this Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants