Skip to content

[SPARK-25213][PYTHON] Add project to v2 scans before python filters. #22206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rdblue wants to merge 4 commits into from
Closed

[SPARK-25213][PYTHON] Add project to v2 scans before python filters. #22206

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ada6e92
SPARK-25213: Add project to v2 scans before python filters.
rdblue Aug 23, 2018
c2e1bc7
SPARK-25213: Add project to v2 scans before python projections.
rdblue Aug 23, 2018
c49157e
SPARK-24213: Fix pyspark style.
rdblue Aug 23, 2018
550368e
SPARK-25213: Fix PySpark test.
rdblue Aug 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
SPARK-25213: Fix PySpark test.
  • Loading branch information
@rdblue
rdblue committed Aug 23, 2018
commit 550368eaeebdc87f2c89bad7214f2624784eeb04
2 changes: 1 addition & 1 deletion python/pyspark/sql/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6399,7 +6399,7 @@ def test_pyspark_udf_SPARK_25213(self):
from pyspark.sql.functions import udf

df = self.spark.read.format("org.apache.spark.sql.sources.v2.SimpleDataSourceV2").load()
Copy link
Member

@HyukjinKwon HyukjinKwon Aug 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test will fail if test classes are not compiled. Can we check if test classes are compiled and then skip if not existent?

result = datasource_v2_df.withColumn('x', udf(lambda x: x, 'int')(datasource_v2_df['i']))
result = df.withColumn('x', udf(lambda x: x, 'int')(df['i']))
Copy link
Member

@viirya viirya Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only tests Project with Scalar PythonUDF? Might be better to also test Filter case.

Copy link
Contributor Author

@rdblue rdblue Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I was just verifying that the fix worked before spending more time on it.

rows = list(map(lambda r: r.asDict(), result.collect()))
expected = [{'i': i, 'j': -i, 'x': i} for i in range(10)]
self.assertEqual(rows, expected)
Expand Down