[SPARK-25218][Core]Fix potential resource leaks in TransportServer and SocketAuthHelper #22210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
commented
Aug 23, 2018
| try { | ||
| if (channel != null) { | ||
| long size = channel.size(); | ||
| throw new IOException("Error in reading " + this + " (actual file length " + size + ")", |
Member
Author
There was a problem hiding this comment.
This is just thrown and then ignored. I assigned it to errorMessage so that we can see it in the error.
zsxwing
commented
Aug 23, 2018
| try { | ||
| if (is != null) { | ||
| long size = file.length(); | ||
| throw new IOException("Error in reading " + this + " (actual file length " + size + ")", |
|
Test build #95184 has finished for PR 22210 at commit
|
Member
Author
|
cc @brkyvz |
Contributor
|
LGTM! Good catches |
Member
|
Seems okay to me too |
Member
Author
|
Thanks! Merging to master. |
bogdanrdc
pushed a commit
to bogdanrdc/spark
that referenced
this pull request
Aug 28, 2018
…nd SocketAuthHelper ## What changes were proposed in this pull request? Make sure TransportServer and SocketAuthHelper close the resources for all types of errors. ## How was this patch tested? Jenkins Closes apache#22210 from zsxwing/SPARK-25218. Authored-by: Shixiong Zhu <[email protected]> Signed-off-by: Shixiong Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make sure TransportServer and SocketAuthHelper close the resources for all types of errors.
How was this patch tested?
Jenkins