[MINOR] Fix Scala 2.12 build #22229
Closed
[MINOR] Fix Scala 2.12 build #22229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM pending tests (not that this should change them). |
|
Test build #95231 has finished for PR 22229 at commit
|
Member
|
retest this please. |
jiangxb1987
approved these changes
Aug 25, 2018
Contributor
jiangxb1987
left a comment
jiangxb1987
left a comment
There was a problem hiding this comment.
LGTM, thanks for catching this!
HyukjinKwon
approved these changes
Aug 25, 2018
|
Test build #95239 has finished for PR 22229 at commit
|
Member
|
Merged to master. |
bogdanrdc
pushed a commit
to bogdanrdc/spark
that referenced
this pull request
Aug 28, 2018
## What changes were proposed in this pull request? [SPARK-25095](apache@ad45299) introduced `ambiguous reference to overloaded definition` ``` [error] /Users/d_tsai/dev/apache-spark/core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala:242: ambiguous reference to overloaded definition, [error] both method addTaskCompletionListener in class TaskContext of type [U](f: org.apache.spark.TaskContext => U)org.apache.spark.TaskContext [error] and method addTaskCompletionListener in class TaskContext of type (listener: org.apache.spark.util.TaskCompletionListener)org.apache.spark.TaskContext [error] match argument types (org.apache.spark.TaskContext => Unit) [error] context.addTaskCompletionListener(_ => server.close()) [error] ^ [error] one error found [error] Compile failed at Aug 24, 2018 1:56:06 PM [31.582s] ``` which fails the Scala 2.12 branch build. ## How was this patch tested? Existing tests Closes apache#22229 from dbtsai/fix-2.12-build. Authored-by: DB Tsai <[email protected]> Signed-off-by: hyukjinkwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-25095 introduced
ambiguous reference to overloaded definitionwhich fails the Scala 2.12 branch build.
How was this patch tested?
Existing tests