[SPARK-23997][SQL][Followup] Update exception message #22269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @gatorsmile |
|
Test build #95425 has finished for PR 22269 at commit
|
Member
|
Retest this please. |
|
Test build #95429 has finished for PR 22269 at commit
|
srowen
approved these changes
Aug 30, 2018
Member
|
Merged to master |
fjh100456
pushed a commit
to fjh100456/spark
that referenced
this pull request
Aug 31, 2018
## What changes were proposed in this pull request? This PR is an follow-up PR of apache#21087 based on [a discussion thread](apache#21087 (comment)]. Since apache#21087 changed a condition of `if` statement, the message in an exception is not consistent of the current behavior. This PR updates the exception message. ## How was this patch tested? Existing UTs Closes apache#22269 from kiszk/SPARK-23997-followup. Authored-by: Kazuaki Ishizaki <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is an follow-up PR of #21087 based on [a discussion thread](https://github.com/apache/spark/pull/21087#discussion_r211080067]. Since #21087 changed a condition of
ifstatement, the message in an exception is not consistent of the current behavior.This PR updates the exception message.
How was this patch tested?
Existing UTs