Skip to content

[SPARK-25274][PYTHON][SQL] In toPandas with Arrow send un-ordered record batches to improve performance #22275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BryanCutler wants to merge 10 commits into from
Closed

[SPARK-25274][PYTHON][SQL] In toPandas with Arrow send un-ordered record batches to improve performance #22275

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
087564e
changed toPandas to send out of order batches, followed by batch orde…
BryanCutler Aug 29, 2018
6073ed9
reorg the batch order deser to simplify
BryanCutler Oct 30, 2018
0d77b00
expanded test for more cases
BryanCutler Oct 30, 2018
7d19977
Merge remote-tracking branch 'upstream/master' into arrow-toPandas-oo…
BryanCutler Oct 30, 2018
6457e42
remove blank line
BryanCutler Oct 30, 2018
bf2feec
add test case with delay
BryanCutler Nov 6, 2018
725cd47
Merge remote-tracking branch 'upstream/master' into arrow-toPandas-oo…
BryanCutler Nov 8, 2018
7dc92c8
fixed some comments
BryanCutler Nov 8, 2018
8045fac
fix comment
BryanCutler Nov 8, 2018
00c7b8c
Merge remote-tracking branch 'upstream/master' into arrow-toPandas-oo…
BryanCutler Dec 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix comment
  • Loading branch information
@BryanCutler
BryanCutler committed Nov 8, 2018
commit 8045facbe523c89b91b930203bb6874d82d08a4d
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3179,7 +3179,7 @@ class Dataset[T] private[sql](
val batchOrder = new ArrayBuffer[(Int, Int)]()
var partitionCount = 0

// Handler to eagerly write batches to Python un-ordered
// Handler to eagerly write batches to Python as they arrive, un-ordered
def handlePartitionBatches(index: Int, arrowBatches: Array[Array[Byte]]): Unit = {
if (arrowBatches.nonEmpty) {
// Write all batches (can be more than 1) in the partition, store the batch order tuple
Expand Down