Skip to content

[SPARK-22357][CORE][FOLLOWUP] SparkContext.binaryFiles ignore minPartitions parameter #22356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srowen wants to merge 2 commits into from
Closed

[SPARK-22357][CORE][FOLLOWUP] SparkContext.binaryFiles ignore minPartitions parameter #22356

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84dd4a7
Add test for binaryFiles minPartitions
srowen Sep 6, 2018
6e1d8fd
Make tests a loop
srowen Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make tests a loop
  • Loading branch information
@srowen
srowen committed Sep 6, 2018
commit 6e1d8fd43091d7b8ad83bda18f4b3701a829dc10
6 changes: 3 additions & 3 deletions core/src/test/scala/org/apache/spark/FileSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,9 +315,9 @@ class FileSuite extends SparkFunSuite with LocalSparkContext {
StandardCharsets.UTF_8)
}

assert(sc.binaryFiles(tempDirPath, minPartitions = 1).getNumPartitions === 1)
assert(sc.binaryFiles(tempDirPath, minPartitions = 2).getNumPartitions === 2)
assert(sc.binaryFiles(tempDirPath, minPartitions = 8).getNumPartitions === 8)
for (p <- Seq(1, 2, 8)) {
assert(sc.binaryFiles(tempDirPath, minPartitions = p).getNumPartitions === p)
}
}

test("fixed record length binary file as byte array") {
Expand Down