Skip to content

Conversation

@michaelmior
Copy link
Member

This is a rework of #21433 to address some concerns there.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SparkQA
Copy link

SparkQA commented Sep 12, 2018

Test build #4336 has finished for PR 22398 at commit 15edc21.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 12, 2018

Test build #4337 has finished for PR 22398 at commit 89ed7b1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Sep 13, 2018

Test build #4339 has finished for PR 22398 at commit 89ed7b1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

since the original PR was reverted from 2.4, I'm merging it back.

Thanks, merging to master/2.4!

asfgit pushed a commit that referenced this pull request Sep 13, 2018
This is a rework of #21433 to address some concerns there.

Closes #22398 from michaelmior/long-callsite2.

Authored-by: Michael Mior <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit ab25c96)
Signed-off-by: Wenchen Fan <[email protected]>
@asfgit asfgit closed this in ab25c96 Sep 13, 2018
fjh100456 pushed a commit to fjh100456/spark that referenced this pull request Sep 13, 2018
This is a rework of apache#21433 to address some concerns there.

Closes apache#22398 from michaelmior/long-callsite2.

Authored-by: Michael Mior <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
@michaelmior
Copy link
Member Author

@cloud-fan Thanks for the merge again! :)

@michaelmior michaelmior deleted the long-callsite2 branch September 13, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants