Skip to content

[SPARK-25497][SQL] Limit operation within whole stage codegen should not consume all the inputs #22524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 6 commits into from
Closed

[SPARK-25497][SQL] Limit operation within whole stage codegen should not consume all the inputs #22524

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
12703bd
limit operation within whole stage codegen should not consume all the…
viirya Sep 22, 2018
a09e60f
Fix limit codegen.
viirya Sep 24, 2018
2f4d356
Address comments.
viirya Sep 25, 2018
6d95b65
Merge remote-tracking branch 'upstream/master' into SPARK-25497
viirya Sep 27, 2018
ed2c269
Fix java style.
viirya Oct 1, 2018
1b2ab61
Add spaces to fix code style.
viirya Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add spaces to fix code style.
  • Loading branch information
@viirya
viirya committed Oct 2, 2018
commit 1b2ab6106f52558c48c8a82af6bda507b5189f64
6 changes: 3 additions & 3 deletions sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2890,7 +2890,7 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext {
.selectExpr("1 + id2 as id3")
sortDF.collect()
val sortNumRecords = sortDF.queryExecution.sparkPlan.collect {
case l@LocalLimitExec(_, f: FilterExec) => f
case l @ LocalLimitExec(_, f: FilterExec) => f
}.map { filterNode =>
filterNode.metrics("numOutputRows").value
}
Expand All @@ -2901,7 +2901,7 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext {
.selectExpr("id + 1 as id2").limit(1).filter('id > 50)
filterDF.collect()
val filterNumRecords = filterDF.queryExecution.sparkPlan.collect {
case f@FilterExec(_, r: RangeExec) => f
case f @ FilterExec(_, r: RangeExec) => f
}.map { case filterNode =>
filterNode.metrics("numOutputRows").value
}.head
Expand All @@ -2915,7 +2915,7 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext {
.filter('id2 >= 0)
twoLimitsDF.collect()
val twoLimitsDFNumRecords = twoLimitsDF.queryExecution.sparkPlan.collect {
case f@FilterExec(_, _: RangeExec) => f
case f @ FilterExec(_, _: RangeExec) => f
}.map { filterNode =>
filterNode.metrics("numOutputRows").value
}.head
Expand Down