[SPARK-25892][SQL]Change AttributeReference.withMetadata's return type to AttributeReference #22918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinyu98
changed the title
xuanyuanking
reviewed
Nov 5, 2018
Member
xuanyuanking
left a comment
xuanyuanking
left a comment
There was a problem hiding this comment.
+1, introduced from SPARK-18124 about watermark implementation.
Member
|
The |
Contributor
Author
|
@xuanyuanking thanks, I fixed. |
Member
|
ok to test |
HyukjinKwon
approved these changes
Dec 27, 2018
|
Test build #100470 has finished for PR 22918 at commit
|
Member
|
Merged to master. |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jan 5, 2019
…pe to AttributeReference ## What changes were proposed in this pull request? Currently the `AttributeReference.withMetadata` method have return type `Attribute`, the rest of with methods in the `AttributeReference` return type are `AttributeReference`, as the [spark-25892](https://issues.apache.org/jira/browse/SPARK-25892?jql=project%20%3D%20SPARK%20AND%20component%20in%20(ML%2C%20PySpark%2C%20SQL)) mentioned. This PR will change `AttributeReference.withMetadata` method's return type from `Attribute` to `AttributeReference`. ## How was this patch tested? Run all `sql/test,` `catalyst/test` and `org.apache.spark.sql.execution.streaming.*` Closes apache#22918 from kevinyu98/spark-25892. Authored-by: Kevin Yu <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…pe to AttributeReference ## What changes were proposed in this pull request? Currently the `AttributeReference.withMetadata` method have return type `Attribute`, the rest of with methods in the `AttributeReference` return type are `AttributeReference`, as the [spark-25892](https://issues.apache.org/jira/browse/SPARK-25892?jql=project%20%3D%20SPARK%20AND%20component%20in%20(ML%2C%20PySpark%2C%20SQL)) mentioned. This PR will change `AttributeReference.withMetadata` method's return type from `Attribute` to `AttributeReference`. ## How was this patch tested? Run all `sql/test,` `catalyst/test` and `org.apache.spark.sql.execution.streaming.*` Closes apache#22918 from kevinyu98/spark-25892. Authored-by: Kevin Yu <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently the
AttributeReference.withMetadatamethod have return typeAttribute, the rest of with methods in theAttributeReferencereturn type areAttributeReference, as the spark-25892 mentioned.This PR will change
AttributeReference.withMetadatamethod's return type fromAttributetoAttributeReference.How was this patch tested?
Run all
sql/test,catalyst/testandorg.apache.spark.sql.execution.streaming.*