Skip to content

[SPARK-26103][SQL] Added maxDepth to limit the length of text plans #23076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DaveDeCaprio wants to merge 8 commits into from
Closed

[SPARK-26103][SQL] Added maxDepth to limit the length of text plans #23076

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
adc4f8e
Added maxDepth to treeString which limits the depth of the printed st…
DaveDeCaprio Nov 18, 2018
3a9743f
Added maxDepth to treeString which limits the depth of the printed st…
DaveDeCaprio Nov 18, 2018
0681f05
Removed outdated changes to QueryExecution
DaveDeCaprio Nov 18, 2018
c4cef02
Whitespace changes
DaveDeCaprio Nov 18, 2018
a3ef2ba
Remove tabs
DaveDeCaprio Nov 18, 2018
7c178ab
Remove tabs
DaveDeCaprio Nov 18, 2018
45d4693
Corrected test condition
DaveDeCaprio Nov 18, 2018
42e4fcf
Reenabled file-based tests
DaveDeCaprio Nov 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Whitespace changes
  • Loading branch information
@DaveDeCaprio
DaveDeCaprio committed Nov 18, 2018
commit c4cef026bf03f383f6c3576543e3c52718fd0676
10 changes: 5 additions & 5 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,9 +484,9 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product with Log
}

def treeString(
writer: Writer,
verbose: Boolean,
addSuffix: Boolean): Unit = {
writer: Writer,
verbose: Boolean,
addSuffix: Boolean): Unit = {
treeString(writer, verbose, addSuffix, TreeNode.maxTreeToStringDepth)
}

Expand All @@ -498,7 +498,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product with Log
generateTreeString(0, Nil, writer, verbose, "", addSuffix, maxDepth)
}

/**
/**
* Returns a string representation of the nodes in this tree, where each operator is numbered.
* The numbers can be used with [[TreeNode.apply]] to easily access specific subtrees.
*
Expand Down Expand Up @@ -599,7 +599,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product with Log
}
else {
if (TreeNode.treeDepthWarningPrinted.compareAndSet(false, true)) {
logWarn(
logWarning(
"Truncated the string representation of a plan since it was nested too deeply. " +
"This behavior can be adjusted by setting 'spark.debug.maxToStringTreeDepth' in " +
"SparkEnv.conf.")
Expand Down