[SPARK-26168][SQL] Update the code comments in Expression and Aggregate #23135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
gatorsmile
changed the title
rxin
reviewed
Nov 25, 2018
| * @param aggregateExpressions expressions for a project list, which could contain | ||
| * [[org.apache.spark.sql.catalyst.expressions.aggregate.AggregateFunction]]s. | ||
| * | ||
| * Note: Currently, aggregateExpressions correspond to both [[AggregateExpression]] and the output |
Contributor
There was a problem hiding this comment.
It is not clear what “resultExpressions” mean.
Member
Author
There was a problem hiding this comment.
Removed it from the description.
srowen
approved these changes
Nov 25, 2018
|
Test build #99246 has finished for PR 23135 at commit
|
kiszk
reviewed
Nov 26, 2018
| * - [[HigherOrderFunction]]: a common base trait for higher order functions that take one or more | ||
| * (lambda) functions and applies these to some objects. The function | ||
| * produces a number of variables which can be consumed by some lambda | ||
| * function. |
kiszk
reviewed
Nov 26, 2018
| * interpreted mode. | ||
| * - [[NullIntolerant]]: an expression that is null intolerant (i.e. any null input will result in | ||
| * null output). | ||
| * - [[NonSQLExpression]]: a common base trait for the expressions that doesn't have SQL |
cloud-fan
reviewed
Nov 26, 2018
| * produces a number of variables which can be consumed by some lambda | ||
| * function. | ||
| * - [[NamedExpression]]: An [[Expression]] that is named. | ||
| * - [[TimeZoneAwareExpression]]: A common base trait for time zone aware expressions. |
Contributor
There was a problem hiding this comment.
shall we also mention SubqueryExpression?
|
Test build #99248 has finished for PR 23135 at commit
|
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
|
Test build #99257 has finished for PR 23135 at commit
|
Contributor
|
thanks, merging to master! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This PR is to improve the code comments to document some common traits and traps about the expression. ## How was this patch tested? N/A Closes apache#23135 from gatorsmile/addcomments. Authored-by: gatorsmile <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to improve the code comments to document some common traits and traps about the expression.
How was this patch tested?
N/A