Skip to content

[SPARK-24063][SS] Add maximum epoch queue threshold for ContinuousExecution #23156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaborgsomogyi wants to merge 10 commits into from
Closed

[SPARK-24063][SS] Add maximum epoch queue threshold for ContinuousExecution #23156

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
72733c5
[SPARK-24063][SS] Add maximum epoch queue threshold for ContinuousExe…
gaborgsomogyi Nov 22, 2018
b0c5056
Merge branch 'master' into SPARK-24063
gaborgsomogyi Dec 7, 2018
357f834
Merge branch 'master' into SPARK-24063
gaborgsomogyi Jan 24, 2019
f6bc301
withSQLConf used and test commented
gaborgsomogyi Jan 28, 2019
96152da
Review fixes:
gaborgsomogyi Feb 22, 2019
43e61ef
Merge branch 'master' into SPARK-24063
gaborgsomogyi Feb 22, 2019
9324c90
AtomicReference used for failure reference
gaborgsomogyi Feb 22, 2019
8a9b67f
Made config public
gaborgsomogyi Feb 25, 2019
41656f1
Review fix
gaborgsomogyi Feb 27, 2019
d67db64
Review fix
gaborgsomogyi Feb 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review fix
  • Loading branch information
@gaborgsomogyi
gaborgsomogyi committed Feb 27, 2019
commit 41656f1218b795f91033e70683684ce014900c3d
6 changes: 3 additions & 3 deletions ...src/main/scala/org/apache/spark/sql/execution/streaming/continuous/EpochCoordinator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,15 +233,15 @@ private[continuous] class EpochCoordinator(
private def checkProcessingQueueBoundaries() = {
if (partitionOffsets.size > epochBacklogQueueSize) {
query.stopInNewThread(new IllegalStateException("Size of the partition offset queue has " +
"exceeded it's maximum"))
"exceeded its maximum"))
}
if (partitionCommits.size > epochBacklogQueueSize) {
query.stopInNewThread(new IllegalStateException("Size of the partition commit queue has " +
"exceeded it's maximum"))
"exceeded its maximum"))
}
if (epochsWaitingToBeCommitted.size > epochBacklogQueueSize) {
query.stopInNewThread(new IllegalStateException("Size of the epoch queue has " +
"exceeded it's maximum"))
"exceeded its maximum"))
}
}

Expand Down
3 changes: 1 addition & 2 deletions ...core/src/test/scala/org/apache/spark/sql/streaming/continuous/EpochCoordinatorSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ class EpochCoordinatorSuite
new SparkContext(
"local[2]", "test-sql-context",
new SparkConf().set("spark.sql.testkey", "true")
.set(CONTINUOUS_STREAMING_EPOCH_BACKLOG_QUEUE_SIZE.key,
epochBacklogQueueSize.toString)))
.set(CONTINUOUS_STREAMING_EPOCH_BACKLOG_QUEUE_SIZE, epochBacklogQueueSize)))

epochCoordinator
= EpochCoordinatorRef.create(writeSupport, stream, query, "test", 1, spark, SparkEnv.get)
Expand Down