Skip to content

[SPARK-26196][SPARK-26281][WebUI] Total tasks title in the stage page is incorrect when there are failed or killed tasks and update duration metrics #23160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shahidki31 wants to merge 3 commits into from
Closed

[SPARK-26196][SPARK-26281][WebUI] Total tasks title in the stage page is incorrect when there are failed or killed tasks and update duration metrics #23160

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbd745a
Total tasks title in the stage page is incorrect
shahidki31 Nov 28, 2018
661566b
change duration as executorRunTime
shahidki31 Dec 1, 2018
5369a86
address comment
shahidki31 Dec 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change duration as executorRunTime
  • Loading branch information
@shahidki31
shahidki31 committed Dec 1, 2018
commit 661566bd51efb40176327a58e5bed5dcfe7cacf0
4 changes: 2 additions & 2 deletions core/src/main/resources/org/apache/spark/ui/static/stagepage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,8 +662,8 @@ $(document).ready(function () {
{data : "launchTime", name: "Launch Time", render: formatDate},
{
data : function (row, type) {
if (row.duration) {
return type === 'display' ? formatDuration(row.duration) : row.duration;
if (row.taskMetrics && row.taskMetrics.executorRunTime) {
return type === 'display' ? formatDuration(row.taskMetrics.executorRunTime) : row.taskMetrics.executorRunTime;
Copy link

@pgandhi999 pgandhi999 Dec 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that makes sense. However, you also need to update the search filter method to not search on duration in StagesResource.scala here:

|| containsValue(f.duration.getOrElse(defaultOptionString))

https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/status/api/v1/StagesResource.scala#L213.

Copy link
Contributor Author

@shahidki31 shahidki31 Dec 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks removed.

} else {
return "";
}
Expand Down