-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-20636] Add the rule TransposeWindow to the optimization batch #23222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
That PR also added an end-to-end test, does this mean that test is not valid? |
|
We can compare the plans and see whether the rule takes an effect. |
|
Test build #99698 has finished for PR 23222 at commit
|
|
Retest this please. |
|
Test build #99701 has finished for PR 23222 at commit
|
jiangxb1987
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Shall we add a SQL tag to the title? |
|
Jenkins passes, which means the previously added end-to-end test can't show the benefit of this rule. We should update it. |
|
I'm not sure how this ended up being omitted. |
|
LGTM |
|
Test build #100219 has finished for PR 23222 at commit
|
|
Test build #100215 has finished for PR 23222 at commit
|
|
Thanks! Merged to master. |
## What changes were proposed in this pull request? This PR is a follow-up of the PR apache#17899. It is to add the rule TransposeWindow the optimizer batch. ## How was this patch tested? The existing tests. Closes apache#23222 from gatorsmile/followupSPARK-20636. Authored-by: gatorsmile <[email protected]> Signed-off-by: gatorsmile <[email protected]>
## What changes were proposed in this pull request? This PR is a follow-up of the PR apache#17899. It is to add the rule TransposeWindow the optimizer batch. ## How was this patch tested? The existing tests. Closes apache#23222 from gatorsmile/followupSPARK-20636. Authored-by: gatorsmile <[email protected]> Signed-off-by: gatorsmile <[email protected]>
What changes were proposed in this pull request?
This PR is a follow-up of the PR #17899. It is to add the rule TransposeWindow the optimizer batch.
How was this patch tested?
The existing tests.