Skip to content

Conversation

@gatorsmile
Copy link
Member

@gatorsmile gatorsmile commented Dec 5, 2018

What changes were proposed in this pull request?

This PR is a follow-up of the PR #17899. It is to add the rule TransposeWindow the optimizer batch.

How was this patch tested?

The existing tests.

@gatorsmile
Copy link
Member Author

cc @ptkool @jiangxb1987 @cloud-fan

@cloud-fan
Copy link
Contributor

That PR also added an end-to-end test, does this mean that test is not valid?

@gatorsmile
Copy link
Member Author

We can compare the plans and see whether the rule takes an effect.

@SparkQA
Copy link

SparkQA commented Dec 5, 2018

Test build #99698 has finished for PR 23222 at commit 1270e89.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Dec 5, 2018

Test build #99701 has finished for PR 23222 at commit 1270e89.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

@jiangxb1987 jiangxb1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiangxb1987
Copy link
Contributor

Shall we add a SQL tag to the title?

@cloud-fan
Copy link
Contributor

cloud-fan commented Dec 5, 2018

Jenkins passes, which means the previously added end-to-end test can't show the benefit of this rule. We should update it.

@ptkool
Copy link
Contributor

ptkool commented Dec 5, 2018

I'm not sure how this ended up being omitted. TransposeWindowSuite will be fine since it creates a simple optimizer from this rule and a few others. The new test added to DataFrameWindowFunctionsSuite should pass with or without this rule added to the optimizer batch.

@cloud-fan
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Dec 17, 2018

Test build #100219 has finished for PR 23222 at commit 083c726.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 17, 2018

Test build #100215 has finished for PR 23222 at commit d540120.

  • This patch fails due to an unknown error code, -9.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

Thanks! Merged to master.

@asfgit asfgit closed this in f6888f7 Dec 17, 2018
holdenk pushed a commit to holdenk/spark that referenced this pull request Jan 5, 2019
## What changes were proposed in this pull request?

This PR is a follow-up of the PR apache#17899. It is to add the rule TransposeWindow the optimizer batch.

## How was this patch tested?
The existing tests.

Closes apache#23222 from gatorsmile/followupSPARK-20636.

Authored-by: gatorsmile <[email protected]>
Signed-off-by: gatorsmile <[email protected]>
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

This PR is a follow-up of the PR apache#17899. It is to add the rule TransposeWindow the optimizer batch.

## How was this patch tested?
The existing tests.

Closes apache#23222 from gatorsmile/followupSPARK-20636.

Authored-by: gatorsmile <[email protected]>
Signed-off-by: gatorsmile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants