[SPARK-26319][SQL][Test] Add appendReadColumns Unit Test for HiveShimSuite #23268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Dec 10, 2018
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
reviewed
Dec 10, 2018
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
Outdated
Show resolved
Hide resolved
Member
|
Let's close this one. |
Member
|
@sadhen What is the motivation of this PR? |
Contributor
Author
|
Nevermind, just do not like the coding style personally. |
Member
|
Let us avoid unnecessary code refactoring, but your test case is welcomed. |
Member
|
Yup, the test looks okay in that way. Let's file a JIRA and only leave the test case. |
Contributor
Author
|
OK, I will modify the PR several hours later. |
|
Test build #99895 has finished for PR 23268 at commit
|
This reverts commit b68e7b1.
da-liii
changed the title
Contributor
Author
|
@HyukjinKwon Please re-review. |
Member
|
Let's fix PR description as well. You can leave the comments above resolved. |
Contributor
Author
|
@HyukjinKwon I've updated the desc. |
|
Test build #99904 has finished for PR 23268 at commit
|
Member
|
Merged to master. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…Suite ## What changes were proposed in this pull request? Add appendReadColumns Unit Test for HiveShimSuite. ## How was this patch tested? ``` $ build/sbt > project hive > testOnly *HiveShimSuite ``` Closes apache#23268 from sadhen/refactor/hiveshim. Authored-by: Darcy Shen <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add appendReadColumns Unit Test for HiveShimSuite.
How was this patch tested?