Skip to content

Conversation

@cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

cleanup some tests to make sure expression is resolved during test.

How was this patch tested?

test-only PR

@cloud-fan
Copy link
Contributor Author

@SparkQA
Copy link

SparkQA commented Dec 12, 2018

Test build #100030 has finished for PR 23297 at commit 9b0f88d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Dec 12, 2018

Test build #100039 has finished for PR 23297 at commit 9b0f88d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor Author

retest this please

@HyukjinKwon
Copy link
Member

Looks good to me

@SparkQA
Copy link

SparkQA commented Dec 13, 2018

Test build #100053 has finished for PR 23297 at commit 9b0f88d.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor Author

This is a test-only PR and doesn't touch Spark R, the R failure is a known issue. I'm merging it to master, thanks!

@asfgit asfgit closed this in 3238e3d Dec 13, 2018
holdenk pushed a commit to holdenk/spark that referenced this pull request Jan 5, 2019
## What changes were proposed in this pull request?

cleanup some tests to make sure expression is resolved during test.

## How was this patch tested?

test-only PR

Closes apache#23297 from cloud-fan/test.

Authored-by: Wenchen Fan <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

cleanup some tests to make sure expression is resolved during test.

## How was this patch tested?

test-only PR

Closes apache#23297 from cloud-fan/test.

Authored-by: Wenchen Fan <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants