[SPARK-26327][SQL][FOLLOW-UP] Refactor the code and restore the metrics name #23328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
commented
Dec 17, 2018
| } | ||
|
|
||
| /** | ||
| * Send the updated metrics to driver, while this function calling, selectedPartitions has |
gatorsmile
commented
Dec 17, 2018
| Map("numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output rows"), | ||
| "numFiles" -> SQLMetrics.createMetric(sparkContext, "number of files"), | ||
| "fileListingTime" -> SQLMetrics.createMetric(sparkContext, "file listing time (ms)"), | ||
| "metadataTime" -> SQLMetrics.createMetric(sparkContext, "metadata time"), |
Member
Author
There was a problem hiding this comment.
the original name is more straightfoward to end users who has no idea about file listing.
Contributor
There was a problem hiding this comment.
I'm not sure we will add more metadata operation and reuse this metrics. Anyway it was not a good idea to do the renaming in a bug fix PR. @xuanyuanking can you create a ticket and send a new PR for renaming?
Member
There was a problem hiding this comment.
Copy that, original thinking is this bug fix is part of https://issues.apache.org/jira/browse/SPARK-26222.
gatorsmile
commented
Dec 17, 2018
| case _ => | ||
| createNonBucketedReadRDD(readFile, selectedPartitions, relation) | ||
| } | ||
| sendDriverMetrics() |
Member
Author
There was a problem hiding this comment.
Line 313 and line 315, both are calling selectedPartitions. Thus, it is safer to say selectedPartitions is initialized before we send the driver-side metrics
Member
Author
Contributor
|
LGTM |
|
Test build #100208 has finished for PR 23328 at commit
|
|
Test build #100209 has finished for PR 23328 at commit
|
| val optimizerMetadataTimeNs = relation.location.metadataOpsTimeNs.getOrElse(0L) | ||
| val startTime = System.nanoTime() | ||
| val ret = relation.location.listFiles(partitionFilters, dataFilters) | ||
| driverMetrics("filesNum") = ret.map(_.files.size.toLong).sum |
|
Test build #100217 has finished for PR 23328 at commit
|
Member
Author
|
Thanks! Merged to master. |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jan 5, 2019
…cs name ## What changes were proposed in this pull request? - The original comment about `updateDriverMetrics` is not right. - Refactor the code to ensure `selectedPartitions ` has been set before sending the driver-side metrics. - Restore the original name, which is more general and extendable. ## How was this patch tested? The existing tests. Closes apache#23328 from gatorsmile/followupSpark-26142. Authored-by: gatorsmile <[email protected]> Signed-off-by: gatorsmile <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…cs name ## What changes were proposed in this pull request? - The original comment about `updateDriverMetrics` is not right. - Refactor the code to ensure `selectedPartitions ` has been set before sending the driver-side metrics. - Restore the original name, which is more general and extendable. ## How was this patch tested? The existing tests. Closes apache#23328 from gatorsmile/followupSpark-26142. Authored-by: gatorsmile <[email protected]> Signed-off-by: gatorsmile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
updateDriverMetricsis not right.selectedPartitionshas been set before sending the driver-side metrics.How was this patch tested?
The existing tests.