[SPARK-26426][SQL]fix ExpresionInfo assert error in windows operation system. #23363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanlin-Lynn
changed the title
Member
|
ok to test |
HyukjinKwon
reviewed
Dec 24, 2018
| assert arguments != null; | ||
| assert examples != null; | ||
| assert examples.isEmpty() || examples.startsWith("\n Examples:"); | ||
| assert examples.isEmpty() || examples.startsWith("\n Examples:") |
Member
There was a problem hiding this comment.
Let's use System.lineSeparator
|
Test build #100415 has finished for PR 23363 at commit
|
|
Test build #100429 has finished for PR 23363 at commit
|
Member
|
Merged to master and branch-2.4. |
asfgit
pushed a commit
that referenced
this pull request
Dec 25, 2018
…n system. ## What changes were proposed in this pull request? fix ExpresionInfo assert error in windows operation system, when running unit tests. ## How was this patch tested? unit tests Closes #23363 from yanlin-Lynn/unit-test-windows. Authored-by: wangyanlin01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jan 5, 2019
…n system. ## What changes were proposed in this pull request? fix ExpresionInfo assert error in windows operation system, when running unit tests. ## How was this patch tested? unit tests Closes apache#23363 from yanlin-Lynn/unit-test-windows. Authored-by: wangyanlin01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…n system. ## What changes were proposed in this pull request? fix ExpresionInfo assert error in windows operation system, when running unit tests. ## How was this patch tested? unit tests Closes apache#23363 from yanlin-Lynn/unit-test-windows. Authored-by: wangyanlin01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 23, 2019
…n system. ## What changes were proposed in this pull request? fix ExpresionInfo assert error in windows operation system, when running unit tests. ## How was this patch tested? unit tests Closes apache#23363 from yanlin-Lynn/unit-test-windows. Authored-by: wangyanlin01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Aug 1, 2019
…n system. ## What changes were proposed in this pull request? fix ExpresionInfo assert error in windows operation system, when running unit tests. ## How was this patch tested? unit tests Closes apache#23363 from yanlin-Lynn/unit-test-windows. Authored-by: wangyanlin01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix ExpresionInfo assert error in windows operation system, when running unit tests.
How was this patch tested?
unit tests