Skip to content

[SPARK-26459][SQL] replace UpdateNullabilityInAttributeReferences with FixNullability #23390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 4 commits into from
Closed

[SPARK-26459][SQL] replace UpdateNullabilityInAttributeReferences with FixNullability #23390

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
feb57c0
reuse the FixNullability rule
cloud-fan Dec 27, 2018
e328ba3
address comments
cloud-fan Dec 28, 2018
5930cd7
fix comment
cloud-fan Dec 28, 2018
bcb5667
address comment
cloud-fan Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix comment
  • Loading branch information
@cloud-fan
cloud-fan committed Jan 10, 2019
commit 5930cd7bbdf653a040d4dd38557dff6adc70265e
2 changes: 1 addition & 1 deletion .../org/apache/spark/sql/catalyst/optimizer/UpdateAttributeNullabilityInOptimizerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class UpdateAttributeNullabilityInOptimizerSuite extends PlanTest {
// nullable AttributeReference to `b`, because both array indexing and map lookup are
// nullable expressions. After optimization, the same attribute is now non-nullable,
// but the AttributeReference is not updated to reflect this. So, we need to update nullability
// by the `UpdateNullabilityInAttributeReferences` rule.
// by the `UpdateAttributeNullability` rule.
val original = rel
.select(GetArrayItem(CreateArray(Seq('a, 'a + 1L)), 0) as "b")
.groupBy($"b")("1")
Expand Down