Skip to content

[SPARK-26450][SQL] Avoid rebuilding map of schema for every column in projection #23392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bersprockets wants to merge 12 commits into from
Closed

[SPARK-26450][SQL] Avoid rebuilding map of schema for every column in projection #23392

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6b66711
Initial commit
bersprockets Dec 12, 2018
a9dbbec
Initial try at helper function
bersprockets Dec 29, 2018
67a943a
Use helper function
bersprockets Dec 31, 2018
3362744
More uses of helper function
bersprockets Dec 31, 2018
306e0a5
Even more uses of helper function
bersprockets Dec 31, 2018
a25b59c
Some clean up
bersprockets Jan 2, 2019
b977d3e
Review feedback
bersprockets Jan 2, 2019
1497d3a
Fix style issue
bersprockets Jan 2, 2019
777c5b4
Move helper function to BindReferences
bersprockets Jan 4, 2019
fbd6787
Handle cases missed before
bersprockets Jan 4, 2019
686e7b5
Review feedback
bersprockets Jan 5, 2019
b1afb3a
Close gap in ExpandExec
bersprockets Jan 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Initial try at helper function
  • Loading branch information
@bersprockets
bersprockets committed Dec 29, 2018
commit a9dbbec649438a5079f8d9826ebe40bdecfef93c
7 changes: 7 additions & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,11 @@ object BindReferences extends Logging {
}
}.asInstanceOf[A] // Kind of a hack, but safe. TODO: Tighten return type when possible.
}

def bindReferences[A <: Expression](
in: Seq[A],
inputSchema: Seq[Attribute]): Seq[A] = {
lazy val inputSchemaAttrSeq: AttributeSeq = inputSchema
in.map(BindReferences.bindReference(_, inputSchemaAttrSeq))
}
}
5 changes: 3 additions & 2 deletions ...t/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ object GenerateOrdering extends CodeGenerator[Seq[SortOrder], Ordering[InternalR
protected def canonicalize(in: Seq[SortOrder]): Seq[SortOrder] =
in.map(ExpressionCanonicalizer.execute(_).asInstanceOf[SortOrder])

protected def bind(in: Seq[SortOrder], inputSchema: Seq[Attribute]): Seq[SortOrder] =
in.map(BindReferences.bindReference(_, inputSchema))
protected def bind(in: Seq[SortOrder], inputSchema: Seq[Attribute]): Seq[SortOrder] = {
BindReferences.bindReferences(in, inputSchema)
}

/**
* Creates a code gen ordering for sorting this schema, in ascending order.
Expand Down