Skip to content

[SPARK-26504][SQL] Rope-wise dumping of Spark plans #23406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 13 commits into from
Closed

[SPARK-26504][SQL] Rope-wise dumping of Spark plans #23406

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
de38cf8
Use append function instead of Writer
MaxGekk Dec 29, 2018
af5c9ed
Fix typo
MaxGekk Dec 29, 2018
0a36a26
StringRope on List
MaxGekk Dec 29, 2018
07ae72d
Tests for StringRope
MaxGekk Dec 29, 2018
f621de7
Porting on StringRope
MaxGekk Dec 29, 2018
ca4aed8
Rope other methods
MaxGekk Dec 29, 2018
d727959
Added docs
MaxGekk Dec 30, 2018
544b80e
Replacing List by ArrayBuffer
MaxGekk Dec 30, 2018
059dcf4
Inline stringOrError
MaxGekk Dec 30, 2018
fe3bbcf
Move appendOrError to QueryPlan
MaxGekk Dec 30, 2018
707c80b
Renaming StringRope to StringConcat
MaxGekk Dec 30, 2018
074e9b8
rope -> concat in tests
MaxGekk Dec 30, 2018
29b62bf
StringBuffer -> StringBuilder
MaxGekk Dec 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rope -> concat in tests
  • Loading branch information
@MaxGekk
MaxGekk committed Dec 30, 2018
commit 074e9b87716cb3c59ef3a4cb59ba39e070886c55
16 changes: 8 additions & 8 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/StringUtilsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,16 @@ class StringUtilsSuite extends SparkFunSuite {
assert(filterPattern(names, " d* ") === Nil)
}

test("string rope") {
def toRope(seq: String*): String = {
seq.foldLeft(new StringConcat())((rope, s) => {rope.append(s); rope}).toString
test("string concatenation") {
def concat(seq: String*): String = {
seq.foldLeft(new StringConcat())((acc, s) => {acc.append(s); acc}).toString
}

assert(new StringConcat().toString == "")
assert(toRope("") == "")
assert(toRope(null) == "")
assert(toRope("a") == "a")
assert(toRope("1", "2") == "12")
assert(toRope("abc", "\n", "123") == "abc\n123")
assert(concat("") == "")
assert(concat(null) == "")
assert(concat("a") == "a")
assert(concat("1", "2") == "12")
assert(concat("abc", "\n", "123") == "abc\n123")
}
}